fix(wallet): exclude live balances from walletStore persistence (Fixes #128) - #133
Merged
cybermax4200 merged 1 commit intoAug 26, 2026
Merged
Conversation
walletStore persisted balance/ecoBalance/usdcBalance through partialize, so a stale MMKV snapshot was served as live data on cold start. Persist only identity fields (isConnected, publicKey, walletType); balances are re-fetched by useStellarWallet on rehydration. Ref: ecotask-network#128 Signed-off-by: waterWang <water.wang@users.noreply.github.com>
cybermax4200
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
walletStorecurrently persistsbalance,ecoBalance, andusdcBalancethroughpartialize, so a stale MMKV snapshot is served as live data on cold start. This PR adds apartializeWalletStatehelper (mirroring the existingpartializeTaskStatepattern) that persists only identity fields (isConnected,publicKey,walletType).Changes
src/store/walletStore.ts— ExtractpartializeWalletStatepure function; persist onlyisConnected,publicKey,walletType. Balances are excluded: they are re-fetched byuseStellarWallet'suseEffecton rehydration.src/__tests__/stores.test.ts— Add tests confirming: (1)partializeexcludes balance fields, and (2) a rehydrated store starts with null balances.Testing
tsc --noEmitpassesCloses #128